Repository navigation
test: harden the two flaky CI tests (Chrome cold start, calendar import) - #90
Merged
Merged
Conversation
render-chrome: a Chrome that did not print its DevTools line within 30 s failed the render (main, run 39812926089). Each launch now waits 20 s, and a stuck or crashed one is killed and launched once more with a new profile; the first test allows both attempts (120 s). A new test uses a fake executable to check the second launch. The process "exit" listener is removed when Chrome exits (MaxListenersExceededWarning). ui: the first test to open the calendar pays the lazy import's cold cost and went past Vitest's 5 s default on a loaded runner; the package now uses Studio's 20 s. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Madraka <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two tests that sometimes failed CI and passed when re-run.
1.
render-chrome: "Chrome did not start" (main, run 39812926089)chromeRenderer: each launch waits 20 s (was 30 s). A Chrome that hangs or crashes on a cold start is killed and launched once more with a new profile.exitlistener is removed when Chrome exits, soMaxListenersExceededWarningis gone.2.
AnalyticsRangePicker"Test timed out in 5000ms"packages/uiwas the only package on Vitest's 5 s default; it now uses Studio's 20 s.Checks:
render-chrome4/4 (twice),packages/ui201/201, Biome clean.🤖 Generated with Claude Code